Skip to content

chore: Updated with snyk react router, and lodash requests.#12221

Merged
dlabaj merged 2 commits intomainfrom
snyk-updates
Jan 28, 2026
Merged

chore: Updated with snyk react router, and lodash requests.#12221
dlabaj merged 2 commits intomainfrom
snyk-updates

Conversation

@dlabaj
Copy link
Contributor

@dlabaj dlabaj commented Jan 27, 2026 •
edited by coderabbitai bot
Loading

Fixes snyk issues that were identified around react router and lodash.

Summary by CodeRabbit

Chores

  • Updated key dependencies to latest compatible versions for improved stability, security, and performance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • packages/react-charts/src/victory/components/ChartCursorTooltip/__snapshots__/ChartCursorFlyout.test.tsx.snap is excluded by !**/*.snap
  • packages/react-charts/src/victory/components/ChartCursorTooltip/__snapshots__/ChartCursorTooltip.test.tsx.snap is excluded by !**/*.snap
  • packages/react-charts/src/victory/components/ChartTooltip/__snapshots__/ChartTooltip.test.tsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

Dependency versions updated across three package.json files: lodash from ^4.17.21 to ^4.17.23 in react-charts and react-table packages, and react-router and react-router-dom from ^7.9.4 to ^7.12.0 in the demo-app-ts package.

Changes

Cohort / File(s) Summary
Lodash version bump
packages/react-charts/package.json, packages/react-table/package.json		 Updated lodash dependency from ^4.17.21 to ^4.17.23
React Router version bump
packages/react-integration/demo-app-ts/package.json		 Updated react-router and react-router-dom dependencies from ^7.9.4 to ^7.12.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: dependency updates for react-router and lodash as identified by Snyk, which are the primary modifications across multiple package.json files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Jan 27, 2026 •
edited
Loading

Preview: https://pf-react-pr-12221.surge.sh

A11y report: https://pf-react-pr-12221-a11y.surge.sh

kmcfaul
kmcfaul reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it appears that some autogenerated ids on a chart snapshot need to be updated for the build first.

@dlabaj dlabaj merged commit 5c03fd3 into main Jan 28, 2026
14 checks passed
@dlabaj dlabaj mentioned this pull request Jan 28, 2026
Closed
6 tasks
@patternfly-build
Copy link
Collaborator

patternfly-build commented Jan 28, 2026

Your changes have been released in:

  • @patternfly/react-charts@8.5.0-prerelease.12
  • @patternfly/react-docs@7.5.0-prerelease.33
  • @patternfly/react-integration@6.5.0-prerelease.8
  • demo-app-ts@6.5.0-prerelease.57
  • @patternfly/react-table@6.5.0-prerelease.29

Thanks for your contribution! 🎉

This was referenced Feb 3, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@KKoukiou KKoukiou Awaiting requested review from KKoukiou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlabaj @patternfly-build @kmcfaul @thatblindgeye